Bug 187479

Summary: Add --traceLLIntExecution and --traceLLIntSlowPath options.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. ysuzuki: review+

Mark Lam
Reported 2018-07-09 13:12:36 PDT
These options are only available if LLINT_TRACING is enabled in LLIntCommon.h. The details: 1. LLINT_TRACING consolidates and replaces LLINT_EXECUTION_TRACING and LLINT_SLOW_PATH_TRACING. 2. Tracing is now guarded behind runtime options --traceLLIntExecution and --traceLLIntSlowPath. This makes it such that enabling LLINT_TRACING doesn't means that we'll continually spammed with logging until we rebuild. 3. Fixed slow path LLINT tracing to work with exception check validation.
Attachments
proposed patch. (18.19 KB, patch)
2018-07-09 13:18 PDT, Mark Lam 		ysuzuki: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-07-09 13:18:29 PDT
Created attachment 344605 [details] proposed patch.
Yusuke Suzuki
Comment 2 2018-07-09 13:38:48 PDT
Comment on attachment 344605 [details] proposed patch. r=me
Saam Barati
Comment 3 2018-07-09 13:40:51 PDT
Comment on attachment 344605 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=344605&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:198 > + dataLog(values...); Can just be dataLogIf(Options... > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:205 > + dataLogLn(values...); Ditto > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:217 > + dataLogF(format, values...); Not sure if we have an it variant of this
Mark Lam
Comment 4 2018-07-09 14:56:44 PDT
Thanks for the reviews. Landed in r233658: <http://trac.webkit.org/r233658>.
Radar WebKit Bug Importer
Comment 5 2018-07-09 14:58:47 PDT
<rdar://problem/41991662>
Note You need to log in before you can comment on or make changes to this bug.