Bug 187474

Summary: [WebCore] Annotate classes with WTF_MAKE_FAST_ALLOCATED as much as possible
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, mark.lam, rniwa, saam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
mark.lam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews100 for mac-sierra none

Yusuke Suzuki
Reported 2018-07-09 09:19:08 PDT
[WebCore] Annotate classes with WTF_MAKE_FAST_ALLOCATED as much as possible
Attachments
Patch (14.46 KB, patch)
2018-07-09 09:20 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (40.74 KB, patch)
2018-07-09 10:47 PDT, Yusuke Suzuki 		mark.lam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.30 MB, application/zip)
2018-07-09 12:00 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-09 09:20:00 PDT
Created attachment 344593 [details] Patch
Mark Lam
Comment 2 2018-07-09 10:06:13 PDT
Comment on attachment 344593 [details] Patch r- for now because all the EWS bots are unhappy.
Yusuke Suzuki
Comment 3 2018-07-09 10:47:55 PDT
Created attachment 344596 [details] Patch
Yusuke Suzuki
Comment 4 2018-07-09 10:49:34 PDT
(In reply to Mark Lam from comment #2) > Comment on attachment 344593 [details] > Patch > > r- for now because all the EWS bots are unhappy. OK, I've uploaded the revised patch, which should make EWS green.
Mark Lam
Comment 5 2018-07-09 11:00:25 PDT
Comment on attachment 344596 [details] Patch r=me if EWS bots are happy.
EWS Watchlist
Comment 6 2018-07-09 12:00:39 PDT
Comment on attachment 344596 [details] Patch Attachment 344596 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8484172 New failing tests: media/media-fullscreen-return-to-inline.html
EWS Watchlist
Comment 7 2018-07-09 12:00:41 PDT
Created attachment 344600 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Yusuke Suzuki
Comment 8 2018-07-09 12:02:14 PDT
(In reply to Build Bot from comment #6) > Comment on attachment 344596 [details] > Patch > > Attachment 344596 [details] did not pass mac-ews (mac): > Output: https://webkit-queues.webkit.org/results/8484172 > > New failing tests: > media/media-fullscreen-return-to-inline.html It is flaky.
Yusuke Suzuki
Comment 9 2018-07-09 12:08:47 PDT
Committed r233650: <https://trac.webkit.org/changeset/233650>
Radar WebKit Bug Importer
Comment 10 2018-07-09 12:09:43 PDT
<rdar://problem/41983692>
Note You need to log in before you can comment on or make changes to this bug.