Bug 187474 - [WebCore] Annotate classes with WTF_MAKE_FAST_ALLOCATED as much as possible
Summary: [WebCore] Annotate classes with WTF_MAKE_FAST_ALLOCATED as much as possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 09:19 PDT by Yusuke Suzuki
Modified: 2018-07-09 12:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.46 KB, patch)
2018-07-09 09:20 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (40.74 KB, patch)
2018-07-09 10:47 PDT, Yusuke Suzuki 		mark.lam: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-sierra (2.30 MB, application/zip)
2018-07-09 12:00 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-09 09:19:08 PDT 
[WebCore] Annotate classes with WTF_MAKE_FAST_ALLOCATED as much as possible
Comment 1 Yusuke Suzuki 2018-07-09 09:20:00 PDT 
Created attachment 344593 [details]
Patch
Comment 2 Mark Lam 2018-07-09 10:06:13 PDT 
Comment on attachment 344593 [details]
Patch

r- for now because all the EWS bots are unhappy.
Comment 3 Yusuke Suzuki 2018-07-09 10:47:55 PDT 
Created attachment 344596 [details]
Patch
Comment 4 Yusuke Suzuki 2018-07-09 10:49:34 PDT 
(In reply to Mark Lam from comment #2)
> Comment on attachment 344593 [details]
> Patch
> 
> r- for now because all the EWS bots are unhappy.

OK, I've uploaded the revised patch, which should make EWS green.
Comment 5 Mark Lam 2018-07-09 11:00:25 PDT 
Comment on attachment 344596 [details]
Patch

r=me if EWS bots are happy.
Comment 6 EWS Watchlist 2018-07-09 12:00:39 PDT 
Comment on attachment 344596 [details]
Patch

Attachment 344596 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8484172

New failing tests:
media/media-fullscreen-return-to-inline.html
Comment 7 EWS Watchlist 2018-07-09 12:00:41 PDT 
Created attachment 344600 [details]
Archive of layout-test-results from ews100 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 8 Yusuke Suzuki 2018-07-09 12:02:14 PDT 
(In reply to Build Bot from comment #6)
> Comment on attachment 344596 [details]
> Patch
> 
> Attachment 344596 [details] did not pass mac-ews (mac):
> Output: https://webkit-queues.webkit.org/results/8484172
> 
> New failing tests:
> media/media-fullscreen-return-to-inline.html

It is flaky.
Comment 9 Yusuke Suzuki 2018-07-09 12:08:47 PDT 
Committed r233650: <https://trac.webkit.org/changeset/233650>
Comment 10 Radar WebKit Bug Importer 2018-07-09 12:09:43 PDT 
<rdar://problem/41983692>