Bug 187472

Summary: [JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Description Yusuke Suzuki 2018-07-09 08:43:15 PDT
[JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Comment 1 Yusuke Suzuki 2018-07-09 08:45:12 PDT
Created attachment 344587 [details]
Patch
Comment 2 EWS Watchlist 2018-07-09 08:48:13 PDT
Attachment 344587 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/VMEntryScope.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp:202:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:393:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.h:124:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:343:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:978:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2018-07-09 10:28:37 PDT
Comment on attachment 344587 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-07-21 06:04:27 PDT
OK, now, branched. Let's land it.
Comment 5 Yusuke Suzuki 2018-07-21 06:10:48 PDT
Committed r234082: <https://trac.webkit.org/changeset/234082>
Comment 6 Radar WebKit Bug Importer 2018-07-21 06:11:16 PDT
<rdar://problem/42463133>