Summary: | [JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, dbates, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Yusuke Suzuki
2018-07-09 08:43:15 PDT
Created attachment 344587 [details]
Patch
Attachment 344587 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.cpp:67: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp:202: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:393: Missing space before { [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:44: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:49: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1113: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.h:124: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:343: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:978: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 9 in 26 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 344587 [details]
Patch
r=me
OK, now, branched. Let's land it. Committed r234082: <https://trac.webkit.org/changeset/234082> |