Bug 187472 - [JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Summary: [JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-09 08:43 PDT by Yusuke Suzuki
Modified: 2018-07-21 06:11 PDT (History)
10 users (show)

See Also:

Attachments
Patch (33.26 KB, patch)
2018-07-09 08:45 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-09 08:43:15 PDT 
[JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Comment 1 Yusuke Suzuki 2018-07-09 08:45:12 PDT 
Created attachment 344587 [details]
Patch
Comment 2 EWS Watchlist 2018-07-09 08:48:13 PDT 
Attachment 344587 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/VMEntryScope.cpp:67:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp:202:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:393:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:44:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:49:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1113:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.h:124:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:343:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:978:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2018-07-09 10:28:37 PDT 
Comment on attachment 344587 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-07-21 06:04:27 PDT 
OK, now, branched. Let's land it.
Comment 5 Yusuke Suzuki 2018-07-21 06:10:48 PDT 
Committed r234082: <https://trac.webkit.org/changeset/234082>
Comment 6 Radar WebKit Bug Importer 2018-07-21 06:11:16 PDT 
<rdar://problem/42463133>