RESOLVED FIXED 187472
[JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function 
https://bugs.webkit.org/show_bug.cgi?id=187472
Summary [JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Yusuke Suzuki
Reported 2018-07-09 08:43:15 PDT
[JSC] Use Function / ScopedLambda / RecursableLambda instead of std::function
Attachments
Patch (33.26 KB, patch)
2018-07-09 08:45 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-09 08:45:12 PDT
Created attachment 344587 [details] Patch
EWS Watchlist
Comment 2 2018-07-09 08:48:13 PDT
Attachment 344587 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/VMEntryScope.cpp:67: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.cpp:202: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:393: Missing space before { [whitespace/braces] [5] ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:44: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/runtime/VMEntryScope.h:49: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:1113: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/heap/HeapSnapshotBuilder.h:124: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:343: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:978: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 9 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Mark Lam
Comment 3 2018-07-09 10:28:37 PDT
Comment on attachment 344587 [details] Patch r=me
Yusuke Suzuki
Comment 4 2018-07-21 06:04:27 PDT
OK, now, branched. Let's land it.
Yusuke Suzuki
Comment 5 2018-07-21 06:10:48 PDT
Committed r234082: <https://trac.webkit.org/changeset/234082>
Radar WebKit Bug Importer
Comment 6 2018-07-21 06:11:16 PDT
<rdar://problem/42463133>
Note You need to log in before you can comment on or make changes to this bug.