Bug 187465

Summary: [JSC] Optimize layout of AccessCase / ProxyableAccessCase to reduce size of ProxyableAccessCase
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews125 for ios-simulator-wk2
none
Patch
none
Patch keith_miller: review+

Yusuke Suzuki
Reported 2018-07-09 04:33:04 PDT
[JSC] Optimize layout of AccessCase / ProxyableAccessCase to reduce size of ProxyableAccessCase
Attachments
Patch (4.85 KB, patch)
2018-07-09 04:40 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2018-07-09 04:47 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (4.95 KB, patch)
2018-07-09 04:50 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.24 MB, application/zip)
2018-07-09 06:38 PDT, EWS Watchlist 		no flags
Details
Patch (5.22 KB, patch)
2018-07-09 06:56 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (5.22 KB, patch)
2018-07-09 07:06 PDT, Yusuke Suzuki 		keith_miller: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-09 04:40:50 PDT
Created attachment 344573 [details] Patch
Yusuke Suzuki
Comment 2 2018-07-09 04:47:56 PDT
Created attachment 344575 [details] Patch
Yusuke Suzuki
Comment 3 2018-07-09 04:50:08 PDT
Created attachment 344576 [details] Patch
EWS Watchlist
Comment 4 2018-07-09 06:38:56 PDT
Comment on attachment 344576 [details] Patch Attachment 344576 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8481820 New failing tests: animations/needs-layout.html
EWS Watchlist
Comment 5 2018-07-09 06:38:58 PDT
Created attachment 344580 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Yusuke Suzuki
Comment 6 2018-07-09 06:56:33 PDT
Created attachment 344582 [details] Patch
Yusuke Suzuki
Comment 7 2018-07-09 07:06:13 PDT
Created attachment 344583 [details] Patch
Keith Miller
Comment 8 2018-07-09 10:00:51 PDT
Comment on attachment 344583 [details] Patch r=me.
Keith Miller
Comment 9 2018-07-09 10:02:48 PDT
Comment on attachment 344583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344583&action=review > Source/JavaScriptCore/bytecode/AccessCase.h:246 > + // It becomes true only if the instance inherits (or it is) ProxyableAccessCase. nit: It bocomes true => m_viaProxy is true > Source/JavaScriptCore/bytecode/AccessCase.h:248 > + // derived classes, which is super frequently allocated. nit: which is => which are.
Yusuke Suzuki
Comment 10 2018-07-09 10:07:00 PDT
Comment on attachment 344583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344583&action=review Thanks! >> Source/JavaScriptCore/bytecode/AccessCase.h:246 >> + // It becomes true only if the instance inherits (or it is) ProxyableAccessCase. > > nit: It bocomes true => m_viaProxy is true Fixed. >> Source/JavaScriptCore/bytecode/AccessCase.h:248 >> + // derived classes, which is super frequently allocated. > > nit: which is => which are. Fixed.
Yusuke Suzuki
Comment 11 2018-07-09 10:08:22 PDT
Committed r233644: <https://trac.webkit.org/changeset/233644>
Radar WebKit Bug Importer
Comment 12 2018-07-09 10:09:19 PDT
<rdar://problem/41977764>
Note You need to log in before you can comment on or make changes to this bug.