| Summary: | run-benchmark should run ARES-6 1.0.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||||
| Component: | Tools / Tests | Assignee: | Filip Pizlo <fpizlo> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dean_johnson, dewei_zhu, ews-watchlist, glenn, lforschler, saam, sam, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Filip Pizlo
2018-07-08 14:50:23 PDT
Created attachment 344552 [details]
the patch
Comment on attachment 344552 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=344552&action=review > Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:41 > + for key in os.environ: > + if key.startswith("__XPC_JSC"): > + env[key] = os.environ[key] > + Ooooops! Will revert. Attachment 344552 [details] did not pass style-queue:
ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 344553 [details]
the patch
Comment on attachment 344553 [details] the patch Clearing flags on attachment: 344553 Committed r233631: <https://trac.webkit.org/changeset/233631> All reviewed patches have been landed. Closing bug. Oops. Thanks for fixing this. We should keep an eye on the bots today as we should expect some change in results. Comment on attachment 344553 [details]
the patch
The same patch will be applied with some warnings:
patching file driver.js
Hunk #1 succeeded at 141 with fuzz 2 (offset 5 lines).
patching file index.html
I'll make a change to update the patch accoringly.
Address in r233700. |