Bug 187419

Summary:

[Curl] Remove unused AuthenticationManager static methods.

Product:

WebKit

Reporter:

Basuke Suzuki <Basuke.Suzuki>

Component:

Platform

Assignee:

Basuke Suzuki <Basuke.Suzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, Basuke.Suzuki, commit-queue, ews-watchlist, Hironori.Fujii, rniwa, webkit-bug-importer, youennf, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
PATCH	ews-watchlist: commit-queue-
Archive of layout-test-results from ews101 for mac-sierra	none
PATCH	none

Description Basuke Suzuki 2018-07-06 15:47:53 PDT

These are not implemented and added accidentally.

Comment 1 Basuke Suzuki 2018-07-06 15:59:03 PDT

Created attachment 344472 [details]
PATCH

I assume we can remove these static method declarations from Source/WebKit/Shared/Authentication/AuthenticationManager.h:

    static void receivedCredential(const WebCore::AuthenticationChallenge&, const WebCore::Credential&);
    static void receivedRequestToContinueWithoutCredential(const WebCore::AuthenticationChallenge&);
    static void receivedCancellation(const WebCore::AuthenticationChallenge&);
    static void receivedRequestToPerformDefaultHandling(const WebCore::AuthenticationChallenge&);
    static void receivedChallengeRejection(const WebCore::AuthenticationChallenge&);

Comment 2 EWS Watchlist 2018-07-06 16:50:34 PDT

Comment on attachment 344472 [details]
PATCH

Attachment 344472 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8461431

New failing tests:
media/media-fullscreen-return-to-inline.html

Comment 3 EWS Watchlist 2018-07-06 16:50:35 PDT

Created attachment 344488 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 4 Fujii Hironori 2018-07-08 22:07:31 PDT

Curl port is the only port to implement the class methods.
You can remove the declarations.
https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Shared/Authentication/AuthenticationManager.h?rev=232613#L83

Comment 5 Basuke Suzuki 2018-07-09 11:38:47 PDT

Created attachment 344599 [details]
PATCH

Comment 6 Basuke Suzuki 2018-07-09 11:40:52 PDT

(In reply to Fujii Hironori from comment #4)
> Curl port is the only port to implement the class methods.
> You can remove the declarations.
> https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Shared/
> Authentication/AuthenticationManager.h?rev=232613#L83

Thanks for confirmation.

Comment 7 Yusuke Suzuki 2018-07-09 11:42:24 PDT

Comment on attachment 344599 [details]
PATCH

r=me

Comment 8 Basuke Suzuki 2018-07-09 12:06:03 PDT

Thanks, Yusuke.

Comment 9 WebKit Commit Bot 2018-07-09 12:23:25 PDT

The commit-queue encountered the following flaky tests while processing attachment 344599 [details]:

media/media-fullscreen-pause-inline.html bug 187387 (author: jeremyj-wk@apple.com)
The commit-queue is continuing to process your patch.

Comment 10 WebKit Commit Bot 2018-07-09 12:23:37 PDT

The commit-queue encountered the following flaky tests while processing attachment 344599 [details]:

media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.

Comment 11 WebKit Commit Bot 2018-07-09 12:33:33 PDT

Comment on attachment 344599 [details]
PATCH

Clearing flags on attachment: 344599

Committed r233654: <https://trac.webkit.org/changeset/233654>

Comment 12 WebKit Commit Bot 2018-07-09 12:33:34 PDT

All reviewed patches have been landed.  Closing bug.

Comment 13 Radar WebKit Bug Importer 2018-07-09 12:34:19 PDT

<rdar://problem/41984802>