Bug 187396

Summary: [iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, darin, ddkilzer, mitz, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andy Estes
Reported 2018-07-06 11:06:27 PDT
[iOS] WKPDFView should show the Data Detectors sheet when long-pressing a URL that Data Detectors can handle
Attachments
Patch (3.06 KB, patch)
2018-07-06 11:09 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (3.09 KB, patch)
2018-07-06 12:39 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-07-06 11:07:07 PDT
rdar://problem/41786980
Andy Estes
Comment 2 2018-07-06 11:09:30 PDT
Created attachment 344429 [details] Patch
Andy Estes
Comment 3 2018-07-06 12:39:41 PDT
Created attachment 344440 [details] Patch
WebKit Commit Bot
Comment 4 2018-07-06 13:09:30 PDT
The commit-queue encountered the following flaky tests while processing attachment 344440 [details]: media/media-fullscreen-pause-inline.html bug 187406 (author: jeremyj-wk@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2018-07-06 13:09:41 PDT
The commit-queue encountered the following flaky tests while processing attachment 344440 [details]: media/media-fullscreen-return-to-inline.html bug 187387 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2018-07-06 13:13:30 PDT
Comment on attachment 344440 [details] Patch Clearing flags on attachment: 344440 Committed r233589: <https://trac.webkit.org/changeset/233589>
WebKit Commit Bot
Comment 7 2018-07-06 13:13:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.