Bug 187392

Summary: WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler() should take in a CompletionHandler
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews202 for win-future none

Chris Dumez
Reported 2018-07-06 09:34:23 PDT
WebResourceLoadStatisticsStore::callHasStorageAccessForFrameHandler() should take in a CompletionHandler instead of a Function.
Attachments
Patch (2.87 KB, patch)
2018-07-06 09:35 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews202 for win-future (13.01 MB, application/zip)
2018-07-06 10:48 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-07-06 09:35:25 PDT
Created attachment 344422 [details] Patch
EWS Watchlist
Comment 2 2018-07-06 10:48:14 PDT
Comment on attachment 344422 [details] Patch Attachment 344422 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8456880 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
EWS Watchlist
Comment 3 2018-07-06 10:48:25 PDT
Created attachment 344428 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
WebKit Commit Bot
Comment 4 2018-07-06 12:33:12 PDT
Comment on attachment 344422 [details] Patch Clearing flags on attachment: 344422 Committed r233587: <https://trac.webkit.org/changeset/233587>
WebKit Commit Bot
Comment 5 2018-07-06 12:33:13 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-07-06 12:35:10 PDT
<rdar://problem/41903206>
Note You need to log in before you can comment on or make changes to this bug.