Bug 187363

Summary: iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
Product: WebKit Reporter: Olivia Barnett <obarnett>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=196102
Attachments:
Description Flags
Patch
none
Patch none

Olivia Barnett
Reported 2018-07-05 14:40:08 PDT
iPad: Scrolling with hardware keyboard while SELECT popover is visible scrolls the page, detaches popover
Attachments
Patch (2.30 KB, patch)
2018-07-05 14:41 PDT, Olivia Barnett 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2018-07-05 15:29 PDT, Olivia Barnett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Olivia Barnett
Comment 1 2018-07-05 14:41:37 PDT
Created attachment 344368 [details] Patch
Tim Horton
Comment 2 2018-07-05 14:51:33 PDT
Comment on attachment 344368 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344368&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3686 > + if (_assistedNodeInformation.elementType != InputType::Select) { I don't think this is quite right, because pageup/pagedown and spacebar will still scroll. Instead, I think you should bail at the top of the function similar to what we do in the isContentEditable case.
Olivia Barnett
Comment 3 2018-07-05 15:29:08 PDT
Created attachment 344374 [details] Patch
Tim Horton
Comment 4 2018-07-05 17:12:12 PDT
Comment on attachment 344374 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344374&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3645 > + if (_assistedNodeInformation.elementType == InputType::Select) We probably want to add other types to this list (are there other kinds of assisted nodes that use popovers?), but this is a good start.
WebKit Commit Bot
Comment 5 2018-07-05 17:40:29 PDT
Comment on attachment 344374 [details] Patch Clearing flags on attachment: 344374 Committed r233553: <https://trac.webkit.org/changeset/233553>
WebKit Commit Bot
Comment 6 2018-07-05 17:40:31 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-07-05 17:41:19 PDT
<rdar://problem/41872234>
Note You need to log in before you can comment on or make changes to this bug.