Bug 187357

Summary:

[ews-build] Add build step to UnApply patch

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dbates, ddkilzer, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187358

Attachments:

Description	Flags
Proposed patch	ap: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future	none

Aakash Jain

Reported 2018-07-05 12:41:50 PDT

When a patch fails to build or fails layout-tests, EWS should unapply the patch and build/test again. We should add the build step to unapply the patch.

Attachments
Proposed patch (1.77 KB, patch) 2018-07-05 13:38 PDT, Aakash Jain	ap: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews204 for win-future (12.88 MB, application/zip) 2018-07-05 17:16 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-07-05 13:38:57 PDT

Created attachment 344360 [details] Proposed patch Tested in http://ews-build.webkit-uat.org/#/builders/9/builds/22

EWS Watchlist

Comment 2 2018-07-05 13:41:27 PDT Comment hidden (obsolete)

Attachment 344360 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:72: [UnApplyPatchIfRequired.__init__] Use of super on an old style class [pylint/E1002] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-07-05 17:16:16 PDT Comment hidden (obsolete)

Comment on attachment 344360 [details] Proposed patch Attachment 344360 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8450316 New failing tests: http/tests/security/local-video-source-from-remote.html

EWS Watchlist

Comment 4 2018-07-05 17:16:26 PDT Comment hidden (obsolete)

Created attachment 344385 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Aakash Jain

Comment 5 2018-07-10 16:43:27 PDT

Committed r233708: <https://trac.webkit.org/changeset/233708>

Radar WebKit Bug Importer

Comment 6 2018-07-10 16:45:16 PDT

<rdar://problem/42047134>

Daniel Bates

Comment 7 2018-07-16 15:41:17 PDT

Comment on attachment 344360 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=344360&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:73 > + super(UnApplyPatchIfRequired, self).__init__(alwaysUseLatest=True, **kwargs) From my understanding setting alwaysUseLatest to true both cleans the working directory and pulls down new source changes. This represents a behavior change from the current EWS. The current EWS actually unapplies the patch. It does this implicitly by cleaning the working directory. That is, it does not both clean the working directory and pull down new source changes.

Note You need to log in before you can comment on or make changes to this bug.