Summary: | REGRESSION (r31081): Focus problems in Gmail 2/Plain text message text | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ruben Bakker <ruben> | ||||||
Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | darin | ||||||
Priority: | P1 | Keywords: | GoogleBug, InRadar, Regression | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
URL: | http://mail.google.com | ||||||||
Attachments: |
|
Description
Ruben Bakker
2008-04-24 23:07:48 PDT
Confirmed with WebKit nightly build r32531. Works correctly with Safari 3.1.1 on Mac OS X Leopard. Thanks for the great bug report, Ruben, and finding where this regressed! I have a fix for this in my tree. Need to make some regression tests now. Created attachment 25993 [details]
patch in progress -- needs regression tests
(In reply to comment #4) > Created an attachment (id=25993) [review] > patch in progress -- needs regression tests > I am the bug reporter: I am not sure if you addressed me by this comment :) BTW: There is a similar focus bug with Gmail 2/Rich text, someone reported this bug: https://bugs.webkit.org/show_bug.cgi?id=14925 (In reply to comment #5) > (In reply to comment #4) > > Created an attachment (id=25993) [review] [review] > > patch in progress -- needs regression tests > > I am the bug reporter: I am not sure if you addressed me by this comment :) Nope. I'm going to make the regression tests myself. I just can't land the fix without tests. No worries. Nothing for you to do. > BTW: There is a similar focus bug with Gmail 2/Rich text, someone reported this > bug: https://bugs.webkit.org/show_bug.cgi?id=14925 OK. That's got a different cause. Created attachment 26005 [details]
patch
Comment on attachment 26005 [details] patch > + ta.selectionStart = 3; > + ta.selectionEnd = 4; > + debug("- set selection so we can test again without a trailing newline"); For consistency with the other steps, you can print the debug message before performing the action. r=me |