Bug 187339

Summary: [GTK][WPE] Remove soup/DownloadSoupErrors.h
Product: WebKit Reporter: Rob Buis <rbuis>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bugs-noreply, calvaris, cgarcia, commit-queue, fred.wang
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Rob Buis 2018-07-05 05:00:30 PDT 
This seems unused.
Comment 1 Rob Buis 2018-07-05 05:56:53 PDT 
Created attachment 344323 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2018-07-05 06:32:19 PDT 
Comment on attachment 344323 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344323&action=review

> Source/WebKit/ChangeLog:7
> +

nit: Maybe just mentioned that the header is not used here.

> Source/WebKit/PlatformGTK.cmake:-372
> -    "${WEBKIT_DIR}/NetworkProcess/Downloads/soup"

Can you do the same for PlatformWPE, please?
Comment 3 Rob Buis 2018-07-05 06:37:24 PDT 
Created attachment 344325 [details]
Patch
Comment 4 Rob Buis 2018-07-05 06:37:49 PDT 
(In reply to Frédéric Wang (:fredw) from comment #2)
> Comment on attachment 344323 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344323&action=review
> 
> > Source/WebKit/ChangeLog:7
> > +
> 
> nit: Maybe just mentioned that the header is not used here.

Done.

> > Source/WebKit/PlatformGTK.cmake:-372
> > -    "${WEBKIT_DIR}/NetworkProcess/Downloads/soup"
> 
> Can you do the same for PlatformWPE, please?

Sure thing, done.
Comment 5 Frédéric Wang (:fredw) 2018-07-05 06:39:32 PDT 
Comment on attachment 344325 [details]
Patch

Thanks!
Comment 6 Carlos Garcia Campos 2018-07-05 06:39:50 PDT 
Comment on attachment 344325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344325&action=review

Thanks

> Source/WebKit/ChangeLog:3
> +        [GTK] Remove soup/DownloadSoupErrors.h

This is not GTK specific, either use [GTK][WPE] or [Soup]

> Source/WebKit/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).

You don't really need to ask for review to remove this :-)
Comment 7 WebKit Commit Bot 2018-07-05 07:18:09 PDT 
Comment on attachment 344325 [details]
Patch

Clearing flags on attachment: 344325

Committed r233518: <https://trac.webkit.org/changeset/233518>
Comment 8 WebKit Commit Bot 2018-07-05 07:18:11 PDT 
All reviewed patches have been landed.  Closing bug.