Bug 187339

Summary: [GTK][WPE] Remove soup/DownloadSoupErrors.h
Product: WebKit Reporter: Rob Buis <rbuis>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bugs-noreply, calvaris, cgarcia, commit-queue, fred.wang
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Rob Buis
Reported 2018-07-05 05:00:30 PDT
This seems unused.
Attachments
Patch (4.09 KB, patch)
2018-07-05 05:56 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2018-07-05 06:37 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-07-05 05:56:53 PDT
Created attachment 344323 [details] Patch
Frédéric Wang (:fredw)
Comment 2 2018-07-05 06:32:19 PDT
Comment on attachment 344323 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344323&action=review > Source/WebKit/ChangeLog:7 > + nit: Maybe just mentioned that the header is not used here. > Source/WebKit/PlatformGTK.cmake:-372 > - "${WEBKIT_DIR}/NetworkProcess/Downloads/soup" Can you do the same for PlatformWPE, please?
Rob Buis
Comment 3 2018-07-05 06:37:24 PDT
Created attachment 344325 [details] Patch
Rob Buis
Comment 4 2018-07-05 06:37:49 PDT
(In reply to Frédéric Wang (:fredw) from comment #2) > Comment on attachment 344323 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344323&action=review > > > Source/WebKit/ChangeLog:7 > > + > > nit: Maybe just mentioned that the header is not used here. Done. > > Source/WebKit/PlatformGTK.cmake:-372 > > - "${WEBKIT_DIR}/NetworkProcess/Downloads/soup" > > Can you do the same for PlatformWPE, please? Sure thing, done.
Frédéric Wang (:fredw)
Comment 5 2018-07-05 06:39:32 PDT
Comment on attachment 344325 [details] Patch Thanks!
Carlos Garcia Campos
Comment 6 2018-07-05 06:39:50 PDT
Comment on attachment 344325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344325&action=review Thanks > Source/WebKit/ChangeLog:3 > + [GTK] Remove soup/DownloadSoupErrors.h This is not GTK specific, either use [GTK][WPE] or [Soup] > Source/WebKit/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). You don't really need to ask for review to remove this :-)
WebKit Commit Bot
Comment 7 2018-07-05 07:18:09 PDT
Comment on attachment 344325 [details] Patch Clearing flags on attachment: 344325 Committed r233518: <https://trac.webkit.org/changeset/233518>
WebKit Commit Bot
Comment 8 2018-07-05 07:18:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.