Bug 187322

Summary: [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, Hironori.Fujii, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews124 for ios-simulator-wk2 none

Thibault Saunier
Reported 2018-07-04 08:47:32 PDT
[WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
Attachments
Patch (1.14 KB, patch)
2018-07-04 08:50 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (2.24 MB, application/zip)
2018-07-04 10:44 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-07-04 08:50:08 PDT
Created attachment 344288 [details] Patch
EWS Watchlist
Comment 2 2018-07-04 10:44:10 PDT
Comment on attachment 344288 [details] Patch Attachment 344288 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8437569 New failing tests: animations/needs-layout.html
EWS Watchlist
Comment 3 2018-07-04 10:44:11 PDT
Created attachment 344293 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Fujii Hironori
Comment 4 2018-07-04 18:48:52 PDT
Some scripts fails if flatpak is not used. > $ ./Tools/Scripts/run-webkit-tests --gtk --release --no-new-test-results fast > Traceback (most recent call last): > File "./Tools/Scripts/run-webkit-tests", line 39, in <module> > flatpakutils.run_in_sandbox_if_available(sys.argv) > File "./Tools/flatpak/flatpakutils.py", line 829, in run_in_sandbox_if_available > if not flatpak_runner.clean_args(): > File "./Tools/flatpak/flatpakutils.py", line 561, in clean_args > port = factory.get(self.platform) > File "/home/fujii/work/webkit/ga/Tools/Scripts/webkitpy/port/factory.py", line 135, in get > raise NotImplementedError('unsupported platform: "%s"' % port_name) > NotImplementedError: unsupported platform: "GTK"
Fujii Hironori
Comment 5 2018-07-04 18:50:28 PDT
Comment on attachment 344288 [details] Patch I also tested and confirmed it works. I'm not a reviewer. Informal LGTM.
Fujii Hironori
Comment 6 2018-07-04 23:14:49 PDT
Zan fixed. https://trac.webkit.org/changeset/233511/webkit
Zan Dobersek
Comment 7 2018-07-05 00:41:08 PDT
Missed this bug. Rolled out my change in r233513 since this addresses it properly. https://trac.webkit.org/changeset/233513/webkit
WebKit Commit Bot
Comment 8 2018-07-05 01:07:48 PDT
Comment on attachment 344288 [details] Patch Clearing flags on attachment: 344288 Committed r233514: <https://trac.webkit.org/changeset/233514>
WebKit Commit Bot
Comment 9 2018-07-05 01:07:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-07-05 01:08:48 PDT
<rdar://problem/41839155>
Note You need to log in before you can comment on or make changes to this bug.