Bug 187311

Summary: MeasurementSet should merge last four segments into two if values are identical.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rniwa: review+

dewei_zhu
Reported 2018-07-03 18:24:37 PDT
MeasurementSet should merge last four segments into two if values are identical.
Attachments
Patch (8.85 KB, patch)
2018-07-03 18:26 PDT, dewei_zhu 		no flags
DetailsFormatted DiffDiff
Patch (9.78 KB, patch)
2018-07-04 03:25 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2018-07-03 18:26:37 PDT
Created attachment 344252 [details] Patch
Ryosuke Niwa
Comment 2 2018-07-03 19:31:15 PDT
Comment on attachment 344252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344252&action=review > Websites/perf.webkit.org/public/v3/models/measurement-set.js:245 > + if (!segmentationSeries.length || value !== segmentationSeries[segmentationSeries.length - 1].value) I think it's cleaner to move this logic to addSegment and rename it to addSegmentMergingIdenticalSegments. The function can then just compare the last value of segmentationSeries and the newly computed value.
dewei_zhu
Comment 3 2018-07-04 03:25:19 PDT
Created attachment 344271 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.