Bug 187298

Summary: Make CallbackMap::invalidate() safe to re-enter
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-07-03 13:25:24 PDT 
Make CallbackMap::invalidate() safe to re-enter.
Comment 1 Chris Dumez 2018-07-03 13:25:38 PDT 
<rdar://problem/41057167>
Comment 2 Chris Dumez 2018-07-03 13:39:01 PDT 
Created attachment 344209 [details]
Patch
Comment 3 Geoffrey Garen 2018-07-03 16:20:34 PDT 
Comment on attachment 344209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344209&action=review

R=me

> Source/WebKit/UIProcess/GenericCallback.h:164
> +    HashMap<uint64_t, T> map = WTFMove(callbackMap);

I would use auto here.
Comment 4 Chris Dumez 2018-07-03 16:26:14 PDT 
Created attachment 344239 [details]
Patch
Comment 5 WebKit Commit Bot 2018-07-03 17:05:46 PDT 
Comment on attachment 344239 [details]
Patch

Clearing flags on attachment: 344239

Committed r233488: <https://trac.webkit.org/changeset/233488>
Comment 6 WebKit Commit Bot 2018-07-03 17:05:47 PDT 
All reviewed patches have been landed.  Closing bug.