Bug 187241

Summary: [LFC] Implement preferred minimum width logic.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews200 for win-future
none
Patch
none
Patch
none
Patch koivisto: review+

alan
Reported 2018-07-01 21:48:44 PDT
and use it for shrink-to-fit.
Attachments
Patch (29.14 KB, patch)
2018-07-01 22:15 PDT, alan 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.91 MB, application/zip)
2018-07-01 23:57 PDT, EWS Watchlist 		no flags
Details
Patch (37.85 KB, patch)
2018-07-02 07:56 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (36.69 KB, patch)
2018-07-02 16:46 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (39.76 KB, patch)
2018-07-03 07:46 PDT, alan 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-07-01 22:15:06 PDT
Created attachment 344074 [details] Patch
EWS Watchlist
Comment 2 2018-07-01 23:56:55 PDT
Comment on attachment 344074 [details] Patch Attachment 344074 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8409408 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html
EWS Watchlist
Comment 3 2018-07-01 23:57:06 PDT
Created attachment 344080 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
alan
Comment 4 2018-07-02 07:56:34 PDT
Created attachment 344103 [details] Patch
alan
Comment 5 2018-07-02 16:46:01 PDT
Created attachment 344147 [details] Patch
alan
Comment 6 2018-07-03 07:46:37 PDT
Created attachment 344188 [details] Patch
Antti Koivisto
Comment 7 2018-07-03 10:30:19 PDT
Comment on attachment 344188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344188&action=review > Source/WebCore/layout/FormattingContext.h:58 > + struct MinimumMaximumIntrinsicWidth { This is bit clunky. Maybe InstrinsicWidthConstraints or something?
alan
Comment 8 2018-07-03 11:29:45 PDT
Committed r233469: <https://trac.webkit.org/changeset/233469>
Radar WebKit Bug Importer
Comment 9 2018-07-03 11:31:15 PDT
<rdar://problem/41784355>
Note You need to log in before you can comment on or make changes to this bug.