Bug 187232

Summary: [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, ews-watchlist, glenn, mcatanzaro, tsaunier, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner none

Thibault Saunier
Reported 2018-07-01 08:08:47 PDT
See commit message.
Attachments
[WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner (4.01 KB, patch)
2018-07-01 08:10 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-07-01 08:10:11 PDT
Created attachment 344049 [details] [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner The place where host tmp folder is mounted changed to /run/host/ we need to take that into account. Also explicitely close temporary files as relying on garbage collection to remove them is a bad idea. Also minor optimization avoiding to compile regex for each backtrace retrieval.
WebKit Commit Bot
Comment 2 2018-07-01 16:51:47 PDT
Comment on attachment 344049 [details] [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner Clearing flags on attachment: 344049 Committed r233411: <https://trac.webkit.org/changeset/233411>
WebKit Commit Bot
Comment 3 2018-07-01 16:51:48 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4 2018-07-01 16:52:16 PDT
<rdar://problem/41704367>
Note You need to log in before you can comment on or make changes to this bug.