Summary: | Perl uninitialized value $isEnabled when running build-jsc using a CMake build | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Daniel Bates <dbates> | ||||
Component: | Tools / Tests | Assignee: | Daniel Bates <dbates> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aakash_jain, clopez, lforschler, mcatanzaro, thorton, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Daniel Bates
2018-06-29 17:04:59 PDT
Following the patch for bug #177338, we no longer encode a default value for feature flags in webkitperl::FeatureList. Created attachment 343978 [details]
Patch
Can someone save me some time, should we enable enable ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES. (In reply to Daniel Bates from comment #3) > Can someone save me some time, should we enable enable > ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current > behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES. We may set this feature flag per: <https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig?rev=233385#L127> (In reply to Daniel Bates from comment #3) > Can someone save me some time, should we enable enable > ENABLE_EXPERIMENTAL_FEATURES when building JSC? For now, I kept the current > behavior and do not enable ENABLE_EXPERIMENTAL_FEATURES. The --no-experimental-features option in build-webkit, added in the patch for bug #177338, is only used by the GTK Linux bots. For now, I am going to keep this bug focused on fixing the uninitialized value error and keep the current behavior of not toggling experimental features when building with CMake. Committed r233386: <https://trac.webkit.org/changeset/233386> |