Bug 187201

Summary:

[ews-build] Add support for JSC-Tests-EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187365

Attachments:

Description	Flags
Patch for compiling JSC	lforschler: review+

Aakash Jain

Reported 2018-06-29 16:11:33 PDT

We should add support for JSC-Tests-EWS. It would involve two main steps: building (Tools/Scripts/build-jsc), and then running jsc tests (Tools/Scripts/run-javascriptcore-tests).

Attachments
Patch for compiling JSC (5.65 KB, patch) 2018-06-29 16:18 PDT, Aakash Jain	lforschler: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-06-29 16:18:13 PDT

Created attachment 343964 [details] Patch for compiling JSC This is part 1 - to compile JSC. Part 2 to run JSC tests will be in separate patch. CompileJSCOnly class is similar to https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py#L253 Sample run: http://ews-build.webkit-uat.org/#/builders/17/builds/5

EWS Watchlist

Comment 2 2018-06-29 16:21:02 PDT Comment hidden (obsolete)

Attachment 343964 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:423: [TestCompileWebKit.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:423: [TestCompileWebKit.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:437: [TestCompileWebKit.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:437: [TestCompileWebKit.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:459: [TestCompileJSCOnly.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:459: [TestCompileJSCOnly.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:473: [TestCompileJSCOnly.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:473: [TestCompileJSCOnly.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 8 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Aakash Jain

Comment 3 2018-07-05 15:02:04 PDT

Committed r233471: <https://trac.webkit.org/changeset/233471>

Radar WebKit Bug Importer

Comment 4 2018-07-05 15:03:24 PDT

<rdar://problem/41866045>

Note You need to log in before you can comment on or make changes to this bug.