Bug 187189

Summary: Regression(r233359): Caused ITP tests to be flaky
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ryanhaddad, webkit-bug-importer, wilander, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187165    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2018-06-29 12:14:10 PDT 
r233359 caused ITP tests to be flaky.
Comment 1 Chris Dumez 2018-06-29 12:23:24 PDT 
Created attachment 343929 [details]
Patch
Comment 2 Chris Dumez 2018-06-29 12:27:24 PDT 
Created attachment 343930 [details]
Patch
Comment 3 youenn fablet 2018-06-29 13:19:31 PDT 
Comment on attachment 343930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343930&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1481
> +    resolveDirectoriesIfNecessary();

That seems a bit odd to call it there but I guess this is fine since this is a method called only by our test infrastructure.
Comment 4 WebKit Commit Bot 2018-06-29 14:00:56 PDT 
Comment on attachment 343930 [details]
Patch

Clearing flags on attachment: 343930

Committed r233371: <https://trac.webkit.org/changeset/233371>
Comment 5 WebKit Commit Bot 2018-06-29 14:00:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-29 14:01:32 PDT 
<rdar://problem/41651469>