Bug 187189 - Regression(r233359): Caused ITP tests to be flaky
Summary: Regression(r233359): Caused ITP tests to be flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 187165
  Show dependency treegraph
 
Reported: 2018-06-29 12:14 PDT by Chris Dumez
Modified: 2018-06-29 14:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.18 KB, patch)
2018-06-29 12:23 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (3.20 KB, patch)
2018-06-29 12:27 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-29 12:14:10 PDT
r233359 caused ITP tests to be flaky.
Comment 1 Chris Dumez 2018-06-29 12:23:24 PDT
Created attachment 343929 [details]
Patch
Comment 2 Chris Dumez 2018-06-29 12:27:24 PDT
Created attachment 343930 [details]
Patch
Comment 3 youenn fablet 2018-06-29 13:19:31 PDT
Comment on attachment 343930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343930&action=review

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1481
> +    resolveDirectoriesIfNecessary();

That seems a bit odd to call it there but I guess this is fine since this is a method called only by our test infrastructure.
Comment 4 WebKit Commit Bot 2018-06-29 14:00:56 PDT
Comment on attachment 343930 [details]
Patch

Clearing flags on attachment: 343930

Committed r233371: <https://trac.webkit.org/changeset/233371>
Comment 5 WebKit Commit Bot 2018-06-29 14:00:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-29 14:01:32 PDT
<rdar://problem/41651469>