Summary: | [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aditya Keerthi <pxlcoder> | ||||||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Mac | ||||||||||||
OS: | macOS 10.13 | ||||||||||||
Attachments: |
|
Description
Aditya Keerthi
2018-06-29 09:45:34 PDT
Created attachment 343921 [details]
Patch
Created attachment 343922 [details]
Patch
Comment on attachment 343922 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343922&action=review > LayoutTests/TestExpectations:2187 > +webkit.org/b/187183 http/tests/security/pasteboard-file-url.html [ Pass Crash ] It's expected to crash?! Created attachment 343954 [details]
Patch
Discussed with Wenson and Tim - we should not crash. Fixed the behavior and added a test. Comment on attachment 343954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343954&action=review > Tools/WebKitTestRunner/TestOptions.h:75 > bool hasSameInitializationOptions(const TestOptions& options) const This will definitely work, but I think it's a bit confusing to have a helper named "hasSameInitializationOptions" if it may return false for two identical TestOptions that both have the runSingly flag. I think this would be a bit less misleading if we: - Check that options.runSingly matches in hasSameInitializationOptions - And also return `!options.runSingly && m_options.hasSameInitializationOptions(options)` from the call site in viewSupportsOptions Created attachment 343961 [details]
Patch
Comment on attachment 343961 [details] Patch Clearing flags on attachment: 343961 Committed r233379: <https://trac.webkit.org/changeset/233379> All reviewed patches have been landed. Closing bug. |