Bug 187156 – REGRESSION (233281): fast/dom/location-new-window-no-crash.html and some other tests are timing out

• Component: Page Loading
• Status: RESOLVED FIXED

[Antti Koivisto]

Tests Timeout:
fast/dom/location-new-window-no-crash.html
http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html	
storage/indexeddb/modern/blob-cursor.html
storage/indexeddb/modern/blob-svg-image.html

[Antti Koivisto]

Created attachment 343852 [details]
patch

[EWS Watchlist]

Attachment 343852 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleTreeResolver.cpp:582:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:584:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 343854 [details]
patch

[EWS Watchlist]

Attachment 343854 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleTreeResolver.cpp:582:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebCore/style/StyleTreeResolver.cpp:584:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Created attachment 343856 [details]
patch

[EWS Watchlist]

Comment on attachment 343856 [details]
patch

Attachment 343856 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8375321

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

[EWS Watchlist]

Created attachment 343870 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Ryan Haddad]

(In reply to Build Bot from comment #6)
> Comment on attachment 343856 [details]
> patch
> 
> Attachment 343856 [details] did not pass win-ews (win):
> Output: https://webkit-queues.webkit.org/results/8375321
> 
> New failing tests:
> http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Looks unrelated to this patch.

[WebKit Commit Bot]

Comment on attachment 343856 [details]
patch

Clearing flags on attachment: 343856

Committed r233341: <https://trac.webkit.org/changeset/233341>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/41608990>

[Darin Adler]

Comment on attachment 343856 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343856&action=review

> Source/WebCore/style/StyleTreeResolver.cpp:633
> +        for (size_t i = 0; i < queue.size(); ++i) {
> +            if (auto* page = queue[i]->page())
> +                page->setMemoryCacheClientCallsEnabled(true);
> +        }

Why not a modern for loop?