Bug 18713

Summary: Inconcistent painting of scrollbars when hovered and sunken
Product: WebKit Reporter: Tor Arne Vestbø <vestbo>
Component: WebKit QtAssignee: Tor Arne Vestbø <vestbo>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows Vista   
URL: http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=torarne/scrollbar-paint-fix
Attachments:
Description Flags
Patch
hausmann: review-
Updated patch hausmann: review+

Description Tor Arne Vestbø 2008-04-24 06:30:49 PDT
Observable only on Vista, since that's the only style that paints scrollbars diffrently for hovered and sunken states, but easily reproducable with a patch to the plastique style. 

1. First time hover paints hover-state, but any hover after that does not.
2. Click on a scollbar paints sunken state, but moving the mouse away from the scrollbar while still pressing down goes back to painting hovered state, instead of keeping the sunken state.
Comment 1 Tor Arne Vestbø 2008-04-25 07:54:16 PDT
Fixed in http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=torarne/scrollbar-paint-fix and integrated into the qtwebkit branch. 

Comment 2 Tor Arne Vestbø 2008-04-25 08:09:25 PDT
Adding patch for review
Comment 3 Tor Arne Vestbø 2008-04-25 08:10:59 PDT
Created attachment 20819 [details]
Patch
Comment 4 Simon Hausmann 2008-04-28 00:02:08 PDT
Looks good to me, but there's a break; missing after the call to d->leaveEvent() in qwebpage.cpp :)
Comment 5 Tor Arne Vestbø 2008-04-28 02:25:14 PDT
Created attachment 20862 [details]
Updated patch
Comment 6 Simon Hausmann 2008-04-28 02:52:30 PDT
Comment on attachment 20862 [details]
Updated patch

Thanks :)
Comment 7 Simon Hausmann 2008-04-28 03:13:47 PDT
Landed in r32613