Bug 187112

Summary: Add some more register state information when we crash in repatchPutById
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch none

Saam Barati
Reported 2018-06-27 12:48:26 PDT
...
Attachments
patch (3.22 KB, patch)
2018-06-27 15:08 PDT, Saam Barati 		mark.lam: review+
DetailsFormatted DiffDiff
patch (1.61 KB, patch)
2018-06-27 16:04 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-06-27 15:08:13 PDT
Created attachment 343756 [details] patch
Mark Lam
Comment 2 2018-06-27 15:14:10 PDT
Comment on attachment 343756 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=343756&action=review r=me > Source/JavaScriptCore/jit/Repatch.cpp:590 > + if (offset != conditionSetOffset) { Add UNLIKELY() around the condition?
Saam Barati
Comment 3 2018-06-27 16:04:36 PDT
Created attachment 343764 [details] patch
WebKit Commit Bot
Comment 4 2018-06-27 17:18:57 PDT
Comment on attachment 343764 [details] patch Clearing flags on attachment: 343764 Committed r233291: <https://trac.webkit.org/changeset/233291>
WebKit Commit Bot
Comment 5 2018-06-27 17:18:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-06-27 17:19:26 PDT
<rdar://problem/41553229>
Note You need to log in before you can comment on or make changes to this bug.