Bug 187106

Summary: Add logging to try to diagnose where we get a null structure.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Archive of layout-test-results from webkit-cq-01 for mac-sierra
none
Patch for landing none

Keith Miller
Reported 2018-06-27 10:59:20 PDT
Add logging to try to diagnose where we get a null structure.
Attachments
Patch (3.64 KB, patch)
2018-06-27 11:09 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.83 KB, patch)
2018-06-27 11:38 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-01 for mac-sierra (480.67 KB, application/zip)
2018-06-27 12:39 PDT, WebKit Commit Bot 		no flags
Details
Patch for landing (3.91 KB, patch)
2018-06-27 13:33 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-06-27 11:09:59 PDT
Created attachment 343729 [details] Patch
Mark Lam
Comment 2 2018-06-27 11:31:37 PDT
Comment on attachment 343729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343729&action=review r=me with additional ChangeLog comment. > Source/JavaScriptCore/ChangeLog:9 > + Add a logging to JSObject::toPrimitive to help diagnose a nullptr > + structure crash. Can you please add a note that this logging is disabled by default, and requires a code change + rebuild to enable it?
Keith Miller
Comment 3 2018-06-27 11:38:36 PDT
Created attachment 343732 [details] Patch for landing
Mark Lam
Comment 4 2018-06-27 11:42:48 PDT
(In reply to Mark Lam from comment #2) > Can you please add a note that this logging is disabled by default, and > requires a code change + rebuild to enable it? I was wrong about this. Keith pointed out (offline) that this is not disabled by default, hence why this code is only here temporarily, and need to be removed eventually.
WebKit Commit Bot
Comment 5 2018-06-27 12:39:10 PDT
Comment on attachment 343732 [details] Patch for landing Rejecting attachment 343732 [details] from commit-queue. Number of test failures exceeded the failure limit. Full output: https://webkit-queues.webkit.org/results/8361086
WebKit Commit Bot
Comment 6 2018-06-27 12:39:11 PDT
Created attachment 343740 [details] Archive of layout-test-results from webkit-cq-01 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-sierra Platform: Mac OS X 10.12.6
Keith Miller
Comment 7 2018-06-27 13:33:00 PDT
Created attachment 343748 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-06-27 14:26:53 PDT
Comment on attachment 343748 [details] Patch for landing Clearing flags on attachment: 343748 Committed r233278: <https://trac.webkit.org/changeset/233278>
WebKit Commit Bot
Comment 9 2018-06-27 14:26:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-06-27 14:29:31 PDT
<rdar://problem/41543626>
Note You need to log in before you can comment on or make changes to this bug.