Bug 187078

Summary: [GTK][WPE] Remove gflags from libwebrtc build
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, cgarcia, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch alex: review+

Yusuke Suzuki
Reported 2018-06-26 19:34:17 PDT
[GTK][WPE] Remove gflags from libwebrtc build
Attachments
Patch (2.32 KB, patch)
2018-06-26 19:37 PDT, Yusuke Suzuki 		alex: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-06-26 19:37:07 PDT
Created attachment 343679 [details] Patch
Alejandro G. Castro
Comment 2 2018-06-27 01:02:59 PDT
Comment on attachment 343679 [details] Patch LGTM, if bots are happy it is great we can avoid that.
Yusuke Suzuki
Comment 3 2018-06-27 01:17:43 PDT
Thanks! mac and ios bots are unrelated since they do not use CMake. They failed with transient errors (connection to git.webkit.org is timing out). gtk-wk2 becomes green. So, I think it is OK.
Yusuke Suzuki
Comment 4 2018-06-27 01:19:10 PDT
Committed r233249: <https://trac.webkit.org/changeset/233249>
Radar WebKit Bug Importer
Comment 5 2018-06-27 01:20:45 PDT
<rdar://problem/41512519>
Note You need to log in before you can comment on or make changes to this bug.