Bug 187026

Summary: Web Inspector: Color picker: can't enter decimal numbers for opacity
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Video] Bug
none
Patch
none
Patch none

Nikita Vasilyev
Reported 2018-06-25 16:50:41 PDT
Created attachment 343558 [details] [Video] Bug 1. Add "color: hsla(0, 0%, 0%, 0.5)" color property 2. Click on the black square before "hsla(0, 0%, 0%, 0.5)" to display the color picker 3. Click on the last text field, "A" 4. Place text caret after "0.5" 5. Press delete Expected: The opacity text field shows "0.|" Actual: The opacity text field shows "0|". Furthermore, pressing delete again doesn't remove "0"! Notes: Also, Up and Down keys only increment between 0 and 1.
Attachments
[Video] Bug (2.54 MB, video/quicktime)
2018-06-25 16:50 PDT, Nikita Vasilyev 		no flags
Details
Patch (3.75 KB, patch)
2018-08-23 11:08 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2018-08-23 21:17 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-06-25 16:51:36 PDT
<rdar://problem/41446500>
Devin Rousso
Comment 2 2018-08-23 11:08:13 PDT
Created attachment 347939 [details] Patch
Blaze Burg
Comment 3 2018-08-23 16:52:12 PDT
Comment on attachment 347939 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=347939&action=review r=me > Source/WebInspectorUI/ChangeLog:12 > + (WI.ColorPicker.prototype._handleColorInputInput): Please explain why this change fixes the problem. It's not obvious.
Devin Rousso
Comment 4 2018-08-23 21:17:59 PDT
Created attachment 347987 [details] Patch
WebKit Commit Bot
Comment 5 2018-08-23 21:55:35 PDT
Comment on attachment 347987 [details] Patch Clearing flags on attachment: 347987 Committed r235273: <https://trac.webkit.org/changeset/235273>
WebKit Commit Bot
Comment 6 2018-08-23 21:55:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.