Bug 187022

Summary:

Remove RELEASE_ASSERT added in r230875

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Brady Eidson

Reported 2018-06-25 16:13:42 PDT

Remove RELEASE_ASSERT added in r230875 https://trac.webkit.org/changeset/230875/webkit Turns out it's hit a lot. Not terribly surprising as there's more than one way a session can be destroyed unpredictably while a web socket might have just asynchronously started its handshake! <rdar://problem/40860061>

Attachments
Patch (3.85 KB, patch) 2018-06-25 16:19 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2018-06-25 16:19:10 PDT

Created attachment 343553 [details] Patch

Brent Fulgham

Comment 2 2018-06-25 16:21:21 PDT

Comment on attachment 343553 [details] Patch Looks great! r=me

Brent Fulgham

Comment 3 2018-06-25 16:21:36 PDT

Comment on attachment 343553 [details] Patch Looks great! r=me.

WebKit Commit Bot

Comment 4 2018-06-25 16:56:07 PDT

Comment on attachment 343553 [details] Patch Clearing flags on attachment: 343553 Committed r233183: <https://trac.webkit.org/changeset/233183>

WebKit Commit Bot

Comment 5 2018-06-25 16:56:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.