Summary: | Null dereference crash un ApplicationCacheGroup::startLoadingEntry() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
Component: | Page Loading | Assignee: | Chris Dumez <cdumez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | beidson, commit-queue, dbates, ews-watchlist, japhet, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Chris Dumez
2018-06-25 13:11:10 PDT
Created attachment 343532 [details]
Patch
Comment on attachment 343532 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343532&action=review > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:907 > + m_entryLoader = ApplicationCacheResourceLoader::create(m_pendingEntries.begin()->value, documentLoader.cachedResourceLoader(), WTFMove(request), [this, requestURL] (auto&& resourceOrError) { We should probably [this, requestURL = WTFMove(requestURL)] > Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:912 > + this->didFailLoadingEntry(error, m_entryLoader ? m_entryLoader->resource()->url() : requestURL); Can we just always use requestURL? Created attachment 343533 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 343533 [details]: performance-api/performance-observer-no-document-leak.html bug 187015 (author: cdumez@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 343533 [details] Patch Clearing flags on attachment: 343533 Committed r233171: <https://trac.webkit.org/changeset/233171> All reviewed patches have been landed. Closing bug. |