Bug 186974

Summary: Web Inspector: Dark Mode: Media query names are unreadable
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, ews-watchlist, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Screenshot] Bug
none
Patch
none
[Screenshot] With patch applied
none
Archive of layout-test-results from ews200 for win-future none

Nikita Vasilyev
Reported 2018-06-23 15:27:06 PDT
Created attachment 343449 [details] [Screenshot] Bug Also, the highlight of the matching bracket is too dark and hard to see.
Attachments
[Screenshot] Bug (65.06 KB, image/png)
2018-06-23 15:27 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.60 KB, patch)
2018-06-23 15:31 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
[Screenshot] With patch applied (66.31 KB, image/png)
2018-06-23 15:32 PDT, Nikita Vasilyev 		no flags
Details
Archive of layout-test-results from ews200 for win-future (12.82 MB, application/zip)
2018-06-23 20:17 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2018-06-23 15:31:47 PDT
Created attachment 343450 [details] Patch
Nikita Vasilyev
Comment 2 2018-06-23 15:32:26 PDT
Created attachment 343451 [details] [Screenshot] With patch applied
EWS Watchlist
Comment 3 2018-06-23 20:17:27 PDT
Comment on attachment 343450 [details] Patch Attachment 343450 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8309279 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
EWS Watchlist
Comment 4 2018-06-23 20:17:38 PDT
Created attachment 343466 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Blaze Burg
Comment 5 2018-06-25 10:08:16 PDT
Comment on attachment 343450 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-06-25 10:38:35 PDT
Comment on attachment 343450 [details] Patch Clearing flags on attachment: 343450 Committed r233154: <https://trac.webkit.org/changeset/233154>
WebKit Commit Bot
Comment 7 2018-06-25 10:38:37 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-06-25 10:40:05 PDT
<rdar://problem/41429085>
Note You need to log in before you can comment on or make changes to this bug.