Bug 186974 - Web Inspector: Dark Mode: Media query names are unreadable
Summary: Web Inspector: Dark Mode: Media query names are unreadable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-23 15:27 PDT by Nikita Vasilyev
Modified: 2018-06-25 10:40 PDT (History)
5 users (show)

See Also:

Attachments
[Screenshot] Bug (65.06 KB, image/png)
2018-06-23 15:27 PDT, Nikita Vasilyev 		no flags Details
Patch (1.60 KB, patch)
2018-06-23 15:31 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Screenshot] With patch applied (66.31 KB, image/png)
2018-06-23 15:32 PDT, Nikita Vasilyev 		no flags Details
Archive of layout-test-results from ews200 for win-future (12.82 MB, application/zip)
2018-06-23 20:17 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-06-23 15:27:06 PDT 
Created attachment 343449 [details]
[Screenshot] Bug

Also, the highlight of the matching bracket is too dark and hard to see.
Comment 1 Nikita Vasilyev 2018-06-23 15:31:47 PDT 
Created attachment 343450 [details]
Patch
Comment 2 Nikita Vasilyev 2018-06-23 15:32:26 PDT 
Created attachment 343451 [details]
[Screenshot] With patch applied
Comment 3 EWS Watchlist 2018-06-23 20:17:27 PDT 
Comment on attachment 343450 [details]
Patch

Attachment 343450 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8309279

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 4 EWS Watchlist 2018-06-23 20:17:38 PDT 
Created attachment 343466 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Blaze Burg 2018-06-25 10:08:16 PDT 
Comment on attachment 343450 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-06-25 10:38:35 PDT 
Comment on attachment 343450 [details]
Patch

Clearing flags on attachment: 343450

Committed r233154: <https://trac.webkit.org/changeset/233154>
Comment 7 WebKit Commit Bot 2018-06-25 10:38:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-06-25 10:40:05 PDT 
<rdar://problem/41429085>