Bug 186973

Summary: [Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, joepeck, keith_miller, mark.lam, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201803
Bug Depends on:    
Bug Blocks: 221107    
Attachments:
Description Flags
Patch
mitz: review+
Patch
none
Patch none

Darin Adler
Reported 2018-06-23 09:11:28 PDT
[Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Attachments
Patch (65.24 KB, patch)
2018-06-23 09:56 PDT, Darin Adler 		mitz: review+
DetailsFormatted DiffDiff
Patch (70.63 KB, patch)
2018-06-29 17:09 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (63.88 KB, patch)
2018-06-30 17:46 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-06-23 09:56:52 PDT
Created attachment 343440 [details] Patch
Darin Adler
Comment 2 2018-06-29 17:09:34 PDT Comment hidden (obsolete)
Darin Adler
Comment 3 2018-06-30 17:46:02 PDT
Created attachment 344027 [details] Patch
Darin Adler
Comment 4 2018-07-01 11:23:59 PDT
Committed r233409: <https://trac.webkit.org/changeset/233409>
Radar WebKit Bug Importer
Comment 5 2018-07-01 11:24:48 PDT
<rdar://problem/41699383>
Keith Miller
Comment 6 2018-07-01 11:49:16 PDT
Comment on attachment 344027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review > Source/JavaScriptCore/API/JSContextInternal.h:33 > - CallbackData *next; > + CallbackData* next; I thought in Objective-C++ code we followed the Objective-C style of putting the * next to the variable name rather than our C++ style?
mitz
Comment 7 2018-07-01 12:14:37 PDT
(In reply to Keith Miller from comment #6) > Comment on attachment 344027 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344027&action=review > > > Source/JavaScriptCore/API/JSContextInternal.h:33 > > - CallbackData *next; > > + CallbackData* next; > > I thought in Objective-C++ code we followed the Objective-C style of putting > the * next to the variable name rather than our C++ style? * placement depends on the type. For Objective-C classes, the * comes after the space.
Darin Adler
Comment 8 2019-09-15 10:47:02 PDT
Comment on attachment 344027 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review > Source/JavaScriptCore/API/JSVirtualMachine.mm:-190 > - [ownedObjects release]; This change should not have been included in the patch, and was a mismerge. It introduced a storage leak fixed in bug 201803.
Note You need to log in before you can comment on or make changes to this bug.