Bug 186942

Summary: [Fullscreen] Home indicator should show and hide with status bar
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Jer Noble
Reported 2018-06-22 14:11:49 PDT
[Fullscreen] Home indicator should show and hide with status bar
Attachments
Patch (3.68 KB, patch)
2018-06-22 14:13 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.18 KB, patch)
2018-06-22 15:08 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-06-22 14:12:17 PDT
<rdar://problem/41302190>
Jer Noble
Comment 2 2018-06-22 14:13:06 PDT
Created attachment 343365 [details] Patch
Tim Horton
Comment 3 2018-06-22 15:03:04 PDT
Comment on attachment 343365 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343365&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:221 > +@synthesize prefersHomeIndicatorAutoHidden=_prefersHomeIndicatorAutoHidden; In general I like to put this at the top.
Jer Noble
Comment 4 2018-06-22 15:08:51 PDT
Created attachment 343373 [details] Patch for landing
WebKit Commit Bot
Comment 5 2018-06-22 15:48:34 PDT
Comment on attachment 343373 [details] Patch for landing Clearing flags on attachment: 343373 Committed r233105: <https://trac.webkit.org/changeset/233105>
WebKit Commit Bot
Comment 6 2018-06-22 15:48:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.