Bug 186942 - [Fullscreen] Home indicator should show and hide with status bar
Summary: [Fullscreen] Home indicator should show and hide with status bar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-22 14:11 PDT by Jer Noble
Modified: 2018-06-22 15:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.68 KB, patch)
2018-06-22 14:13 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (4.18 KB, patch)
2018-06-22 15:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-06-22 14:11:49 PDT 
[Fullscreen] Home indicator should show and hide with status bar
Comment 1 Jer Noble 2018-06-22 14:12:17 PDT 
<rdar://problem/41302190>
Comment 2 Jer Noble 2018-06-22 14:13:06 PDT 
Created attachment 343365 [details]
Patch
Comment 3 Tim Horton 2018-06-22 15:03:04 PDT 
Comment on attachment 343365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343365&action=review

> Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:221
> +@synthesize prefersHomeIndicatorAutoHidden=_prefersHomeIndicatorAutoHidden;

In general I like to put this at the top.
Comment 4 Jer Noble 2018-06-22 15:08:51 PDT 
Created attachment 343373 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-06-22 15:48:34 PDT 
Comment on attachment 343373 [details]
Patch for landing

Clearing flags on attachment: 343373

Committed r233105: <https://trac.webkit.org/changeset/233105>
Comment 6 WebKit Commit Bot 2018-06-22 15:48:36 PDT 
All reviewed patches have been landed.  Closing bug.