| Summary: | Do not do early processing of incoming sync IPC unless we're waiting for a sync IPC reply | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||||
| Status: | RESOLVED INVALID | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, andersca, beidson, bfulgham, commit-queue, ews-watchlist, ggaren, pvollan, rniwa, sam, webkit-bug-importer | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Bug Depends on: | |||||||||||||||||||||
| Bug Blocks: | 189948 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Chris Dumez
2018-06-22 14:10:55 PDT
Created attachment 343366 [details]
WIP Patch
Created attachment 343367 [details]
Patch
Comment on attachment 343367 [details] Patch Attachment 343367 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8296126 New failing tests: plugins/update-widgets-crash.html Created attachment 343376 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 343384 [details]
Patch
Comment on attachment 343384 [details] Patch Attachment 343384 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8300781 New failing tests: http/tests/misc/blob-size.html Created attachment 343421 [details]
Archive of layout-test-results from ews201 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 350429 [details]
Patch
Comment on attachment 350429 [details] Patch Attachment 350429 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9305449 New failing tests: http/tests/misc/blob-size.html Created attachment 350467 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
My new test is crashing on Windows but the attached archive does not contain a crash trace :/ Also note that my code change is WebKit2-specific so it is merely my new test findings a pre-existing Windows port bug related to blobs. Created attachment 350643 [details]
Patch
Comment on attachment 350643 [details] Patch Clearing flags on attachment: 350643 Committed r236420: <https://trac.webkit.org/changeset/236420> All reviewed patches have been landed. Closing bug. Reverted r236420 and r236458 for reason: This change is not fully correct Committed r236487: <https://trac.webkit.org/changeset/236487> Add too much complexity as it makes it so that 2 synchronous IPC messages may no longer get processed in order. |