Bug 186941

Summary:

Do not do early processing of incoming sync IPC unless we're waiting for a sync IPC reply

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebKit2

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

achristensen, andersca, beidson, bfulgham, commit-queue, ews-watchlist, ggaren, pvollan, rniwa, sam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

189948

Attachments:

Description	Flags
WIP Patch	none
Patch	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Archive of layout-test-results from ews201 for win-future	none
Patch	none
Archive of layout-test-results from ews206 for win-future	none
Patch	none

Chris Dumez

Reported 2018-06-22 14:10:55 PDT

Do not do early processing of incoming sync IPC unless we're waiting for a sync IPC reply.

Attachments
WIP Patch (2.40 KB, patch) 2018-06-22 14:14 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (5.08 KB, patch) 2018-06-22 14:28 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (3.04 MB, application/zip) 2018-06-22 15:37 PDT, EWS Watchlist	no flags	Details
Patch (5.53 KB, patch) 2018-06-22 15:54 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews201 for win-future (12.75 MB, application/zip) 2018-06-22 22:09 PDT, EWS Watchlist	no flags	Details
Patch (5.43 KB, patch) 2018-09-21 14:26 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews206 for win-future (12.78 MB, application/zip) 2018-09-21 18:21 PDT, EWS Watchlist	no flags	Details
Patch (6.18 KB, patch) 2018-09-24 09:10 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2018-06-22 14:14:14 PDT

Created attachment 343366 [details] WIP Patch

Chris Dumez

Comment 2 2018-06-22 14:28:19 PDT

Created attachment 343367 [details] Patch

EWS Watchlist

Comment 3 2018-06-22 15:37:55 PDT

Comment on attachment 343367 [details] Patch Attachment 343367 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8296126 New failing tests: plugins/update-widgets-crash.html

EWS Watchlist

Comment 4 2018-06-22 15:37:57 PDT

Created attachment 343376 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Chris Dumez

Comment 5 2018-06-22 15:54:34 PDT

Created attachment 343384 [details] Patch

EWS Watchlist

Comment 6 2018-06-22 22:09:42 PDT

Comment on attachment 343384 [details] Patch Attachment 343384 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8300781 New failing tests: http/tests/misc/blob-size.html

EWS Watchlist

Comment 7 2018-06-22 22:09:54 PDT

Created attachment 343421 [details] Archive of layout-test-results from ews201 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews201 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Chris Dumez

Comment 8 2018-09-21 14:26:28 PDT

Created attachment 350429 [details] Patch

EWS Watchlist

Comment 9 2018-09-21 18:20:33 PDT

Comment on attachment 350429 [details] Patch Attachment 350429 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9305449 New failing tests: http/tests/misc/blob-size.html

EWS Watchlist

Comment 10 2018-09-21 18:21:05 PDT

Created attachment 350467 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Chris Dumez

Comment 11 2018-09-24 09:05:16 PDT

My new test is crashing on Windows but the attached archive does not contain a crash trace :/ Also note that my code change is WebKit2-specific so it is merely my new test findings a pre-existing Windows port bug related to blobs.

Chris Dumez

Comment 12 2018-09-24 09:10:34 PDT

Created attachment 350643 [details] Patch

Chris Dumez

Comment 13 2018-09-24 12:44:13 PDT

Comment on attachment 350643 [details] Patch Clearing flags on attachment: 350643 Committed r236420: <https://trac.webkit.org/changeset/236420>

Chris Dumez

Comment 14 2018-09-24 12:44:15 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 15 2018-09-24 12:45:37 PDT

<rdar://problem/44736030>

Chris Dumez

Comment 16 2018-09-25 16:29:42 PDT

Reverted r236420 and r236458 for reason: This change is not fully correct Committed r236487: <https://trac.webkit.org/changeset/236487>

Chris Dumez

Comment 17 2018-10-01 12:31:57 PDT

Add too much complexity as it makes it so that 2 synchronous IPC messages may no longer get processed in order.

Note You need to log in before you can comment on or make changes to this bug.