Bug 186935

Summary: Expose colorFilterEnabled SPI in WKPreferencesPrivate
Product: WebKit Reporter: Luming Yin <luming_yin>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, luming_yin, realdawei, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for bug 186935.
thorton: review-
Updated patch for bug 186935. none

Luming Yin
Reported 2018-06-22 11:55:16 PDT
We should expose the colorFilterEnabled SPI in WKPreferencesPrivate.
Attachments
Patch for bug 186935. (2.34 KB, patch)
2018-06-22 12:09 PDT, Luming Yin 		thorton: review-
DetailsFormatted DiffDiff
Updated patch for bug 186935. (2.35 KB, patch)
2018-06-22 12:17 PDT, Luming Yin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luming Yin
Comment 1 2018-06-22 12:09:58 PDT
Created attachment 343350 [details] Patch for bug 186935.
Tim Horton
Comment 2 2018-06-22 12:14:15 PDT
Comment on attachment 343350 [details] Patch for bug 186935. View in context: https://bugs.webkit.org/attachment.cgi?id=343350&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:140 > +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); Needs WK_IOS_TBA
Luming Yin
Comment 3 2018-06-22 12:17:01 PDT
Created attachment 343351 [details] Updated patch for bug 186935.
WebKit Commit Bot
Comment 4 2018-06-22 12:56:48 PDT
Comment on attachment 343351 [details] Updated patch for bug 186935. Clearing flags on attachment: 343351 Committed r233089: <https://trac.webkit.org/changeset/233089>
WebKit Commit Bot
Comment 5 2018-06-22 12:56:49 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-06-22 12:57:20 PDT
<rdar://problem/41378619>
Dawei Fenton (:realdawei)
Comment 7 2018-06-22 13:11:34 PDT
Looks like this patch broke the iOS build sample output: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6738/steps/compile-webkit/logs/stdio ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/slave/ios-simulator-11-release/build/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKPreferences-77E55B3F73300247.o UIProcess/API/Cocoa/WKPreferences.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure)
Tim Horton
Comment 8 2018-06-22 13:17:38 PDT
I’ll fix it.
Tim Horton
Comment 9 2018-06-22 13:21:29 PDT
Build fix in https://trac.webkit.org/changeset/233094/webkit
Note You need to log in before you can comment on or make changes to this bug.