Summary: | Disable WebSocket in WatchOS | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aestes, ap, commit-queue, ews-watchlist, jbedard, thorton, webkit-bug-importer, wenson_hsieh | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
youenn fablet
2018-06-22 10:44:17 PDT
Created attachment 343344 [details]
Patch
+ jbedard Do you remember if we can currently run http tests on watchOS? IIUC, running http tests on watch simulator is blocked by <rdar://problem/39141677>... Comment on attachment 343344 [details] Patch Attachment 343344 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8293435 New failing tests: performance-api/performance-observer-no-document-leak.html Created attachment 343353 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Wenson Hsieh from comment #3) > + jbedard > > Do you remember if we can currently run http tests on watchOS? IIUC, running > http tests on watch simulator is blocked by <rdar://problem/39141677>... Jonathan confirmed this on IRC. Youenn, can we make this a non-http layout test? OK, I will move it some non http folder. Created attachment 343364 [details]
Patch
Created attachment 343390 [details]
Patch for landing, fixing path to testharness.js
Comment on attachment 343390 [details] Patch for landing, fixing path to testharness.js Clearing flags on attachment: 343390 Committed r233119: <https://trac.webkit.org/changeset/233119> All reviewed patches have been landed. Closing bug. Comment on attachment 343390 [details] Patch for landing, fixing path to testharness.js View in context: https://bugs.webkit.org/attachment.cgi?id=343390&action=review > LayoutTests/ChangeLog:11 > + * fast/dom/Window/watchos/no-websocket-in-watchos.html: Added. Are tests in this directory run in watchOS at all either? (In reply to Alexey Proskuryakov from comment #12) > Comment on attachment 343390 [details] > Patch for landing, fixing path to testharness.js > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343390&action=review > > > LayoutTests/ChangeLog:11 > > + * fast/dom/Window/watchos/no-websocket-in-watchos.html: Added. > > Are tests in this directory run in watchOS at all either? Test expectations for watchOS in our internal repo have: fast/dom/Window/watchos [ Pass ] |