Bug 186915

Summary: [GTK] WebDriver: use a dictionary for session capabilities in StartAutomationSession message
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2018-06-22 05:21:52 PDT
Instead of growing the message signature every we add a new capability, use a dictionary a{sv} and simply add new entries when new capabilities are added. This way we won't need to change the message signature anymore. This broke the test webkit/WebKitAutomationSession/request-session because we changed the signature twice but we didn't update the test.
Attachments
Patch (10.63 KB, patch)
2018-06-22 05:28 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-06-22 05:28:16 PDT
Created attachment 343320 [details] Patch
EWS Watchlist
Comment 2 2018-06-22 05:31:11 PDT
Attachment 343320 [details] did not pass style-queue: ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:287: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Garcia Campos
Comment 3 2018-06-22 06:24:04 PDT
Committed r233077: <https://trac.webkit.org/changeset/233077>
Note You need to log in before you can comment on or make changes to this bug.