Bug 186911

Summary: [CMake] Generated sources depending on SelectorPseudoClassAndCompatibilityElementMap.in are not regenerated
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar, LayoutTestFailure
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mcatanzaro: review+
Archive of layout-test-results from ews114 for mac-sierra none

Carlos Garcia Campos
Reported 2018-06-22 00:40:01 PDT
This is causing test fullscreen/fullscreen-env.html to fail since it was added in r233066 in the bots that didn't start a clean build. The problem is that the CMake command to generate SelectorPseudoClassAndCompatibilityElementMap.cpp doesn't depend on SelectorPseudoClassAndCompatibilityElementMap.in.
Attachments
Patch (2.73 KB, patch)
2018-06-22 00:42 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-sierra (3.00 MB, application/zip)
2018-06-22 02:19 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-06-22 00:42:03 PDT
Created attachment 343312 [details] Patch
EWS Watchlist
Comment 2 2018-06-22 02:19:51 PDT
Comment on attachment 343312 [details] Patch Attachment 343312 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8287887 New failing tests: performance-api/performance-observer-no-document-leak.html
EWS Watchlist
Comment 3 2018-06-22 02:19:53 PDT
Created attachment 343314 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Carlos Garcia Campos
Comment 4 2018-06-22 06:22:23 PDT
Committed r233076: <https://trac.webkit.org/changeset/233076>
Radar WebKit Bug Importer
Comment 5 2018-06-22 06:23:19 PDT
<rdar://problem/41365998>
Note You need to log in before you can comment on or make changes to this bug.