Bug 186890

Summary: Fix encoding / decoding issues in ResourceLoadStatistics
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED WONTFIX    
Severity: Normal CC: bfulgham, commit-queue, dbates, ews-watchlist, japhet, rniwa, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2 none

Chris Dumez
Reported 2018-06-21 12:44:36 PDT
Fix encoding / decoding issues in ResourceLoadStatistics.
Attachments
Patch (6.64 KB, patch)
2018-06-21 12:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.10 MB, application/zip)
2018-06-21 17:22 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-06-21 12:53:47 PDT
Created attachment 343259 [details] Patch
EWS Watchlist
Comment 2 2018-06-21 17:22:53 PDT
Comment on attachment 343259 [details] Patch Attachment 343259 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8283356 New failing tests: accessibility/mac/selection-notification-focus-change.html
EWS Watchlist
Comment 3 2018-06-21 17:22:55 PDT
Created attachment 343296 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Chris Dumez
Comment 4 2018-06-26 13:40:49 PDT
ping review?
Brent Fulgham
Comment 5 2018-06-28 09:46:53 PDT
Comment on attachment 343259 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-06-28 10:07:39 PDT
Comment on attachment 343259 [details] Patch Clearing flags on attachment: 343259 Committed r233309: <https://trac.webkit.org/changeset/233309>
WebKit Commit Bot
Comment 7 2018-06-28 10:07:41 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-06-28 10:10:53 PDT
<rdar://problem/41586938>
Chris Dumez
Comment 9 2018-06-28 13:17:42 PDT
Reverted r233309 for reason: Invalidates previous database model without versioning Committed r233320: <https://trac.webkit.org/changeset/233320>
Note You need to log in before you can comment on or make changes to this bug.