Bug 186890 - Fix encoding / decoding issues in ResourceLoadStatistics
Summary: Fix encoding / decoding issues in ResourceLoadStatistics
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-06-21 12:44 PDT by Chris Dumez
Modified: 2018-07-03 15:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.64 KB, patch)
2018-06-21 12:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.10 MB, application/zip)
2018-06-21 17:22 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-06-21 12:44:36 PDT 
Fix encoding / decoding issues in ResourceLoadStatistics.
Comment 1 Chris Dumez 2018-06-21 12:53:47 PDT 
Created attachment 343259 [details]
Patch
Comment 2 EWS Watchlist 2018-06-21 17:22:53 PDT 
Comment on attachment 343259 [details]
Patch

Attachment 343259 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8283356

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 3 EWS Watchlist 2018-06-21 17:22:55 PDT 
Created attachment 343296 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 Chris Dumez 2018-06-26 13:40:49 PDT 
ping review?
Comment 5 Brent Fulgham 2018-06-28 09:46:53 PDT 
Comment on attachment 343259 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-06-28 10:07:39 PDT 
Comment on attachment 343259 [details]
Patch

Clearing flags on attachment: 343259

Committed r233309: <https://trac.webkit.org/changeset/233309>
Comment 7 WebKit Commit Bot 2018-06-28 10:07:41 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-06-28 10:10:53 PDT 
<rdar://problem/41586938>
Comment 9 Chris Dumez 2018-06-28 13:17:42 PDT 
Reverted r233309 for reason:

Invalidates previous database model without versioning

Committed r233320: <https://trac.webkit.org/changeset/233320>