Bug 186885

Summary: [GLIB] improve get_type() fast path in WEBKIT_DEFINE_TYPE
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, aperez, benjamin, bugs-noreply, calvaris, cdumez, cmarcelo, dbates, ews-watchlist, webkit-bug-importer, zan
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugzilla.gnome.org/show_bug.cgi?id=795180
Attachments:
Description Flags
Patch
none
Updated patch andersca: review+

Description Carlos Garcia Campos 2018-06-21 03:20:39 PDT 
This is a backport of glib commit https://gitlab.gnome.org/GNOME/glib/commit/e924f777369710221c3e0a9d7bf40392a27d1fa4.
Comment 1 Carlos Garcia Campos 2018-06-21 03:25:24 PDT 
Created attachment 343230 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-06-21 03:57:36 PDT 
Created attachment 343232 [details]
Updated patch

Use NEVER_INLINE instead of G_GNUC_NO_INLINE to fix the build with older versions of glib.
Comment 3 Adrian Perez 2018-06-21 04:12:34 PDT 
Comment on attachment 343232 [details]
Updated patch

It's lovely to see this change being ported to the WebKit macros. R+!
Comment 4 Carlos Garcia Campos 2018-06-21 23:41:23 PDT 
Committed r233071: <https://trac.webkit.org/changeset/233071>
Comment 5 Radar WebKit Bug Importer 2018-06-21 23:42:19 PDT 
<rdar://problem/41358076>