Bug 186884

Summary: [GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, berto, cgarcia, ews-watchlist, gustavo, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cgarcia: review+, cgarcia: commit-queue-

Zan Dobersek
Reported 2018-06-21 03:00:16 PDT
[GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions
Attachments
Patch (12.63 KB, patch)
2018-06-21 03:17 PDT, Zan Dobersek 		cgarcia: review+
cgarcia: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-06-21 03:17:12 PDT
Created attachment 343229 [details] Patch
EWS Watchlist
Comment 2 2018-06-21 03:18:57 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2018-06-21 03:41:19 PDT
Comment on attachment 343229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343229&action=review > Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:135 > + while (g_variant_iter_loop(certificates.get(), "(ss)", &host, &certificateFile)) You are getting copies here, you need to use "(&s&s)"
Zan Dobersek
Comment 4 2018-06-21 04:04:01 PDT
Committed r233035: <https://trac.webkit.org/changeset/233035>
Radar WebKit Bug Importer
Comment 5 2018-06-21 04:04:19 PDT
<rdar://problem/41324941>
Note You need to log in before you can comment on or make changes to this bug.