Bug 186873

Summary: JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, joepeck, keith_miller, kondapallykalyan, mark.lam, realdawei, saam, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=215158
Bug Depends on: 186938    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-06-20 19:53:25 PDT
JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up.
Attachments
Patch (13.91 KB, patch)
2018-06-20 20:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (16.95 KB, patch)
2018-06-21 10:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-06-20 19:53:34 PDT
<rdar://problem/41271574>
Chris Dumez
Comment 2 2018-06-20 20:04:05 PDT
Created attachment 343205 [details] Patch
Simon Fraser (smfr)
Comment 3 2018-06-21 08:42:01 PDT
Comment on attachment 343205 [details] Patch Nice but can we also add a test that the Document is not permanently leaked?
Chris Dumez
Comment 4 2018-06-21 08:50:01 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 343205 [details] > Patch > > Nice but can we also add a test that the Document is not permanently leaked? Sure, how do I do that?
Chris Dumez
Comment 5 2018-06-21 10:24:23 PDT
(In reply to Chris Dumez from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > Comment on attachment 343205 [details] > > Patch > > > > Nice but can we also add a test that the Document is not permanently leaked? > > Sure, how do I do that? Just found internals.numberOfLiveDocuments(), will try this.
Chris Dumez
Comment 6 2018-06-21 10:52:56 PDT
Created attachment 343247 [details] Patch
WebKit Commit Bot
Comment 7 2018-06-21 12:04:09 PDT
Comment on attachment 343247 [details] Patch Clearing flags on attachment: 343247 Committed r233053: <https://trac.webkit.org/changeset/233053>
WebKit Commit Bot
Comment 8 2018-06-21 12:04:11 PDT
All reviewed patches have been landed. Closing bug.
Dawei Fenton (:realdawei)
Comment 9 2018-06-22 10:07:05 PDT
Looks like test performance-api/performance-observer-no-document-leak.html is timing out on all platforms: Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=performance-api%2Fperformance-observer-no-document-leak.html Sample results: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/6137/steps/layout-test/logs/stdio Regressions: Unexpected timeouts (1) performance-api/performance-observer-no-document-leak.html [ Timeout ]
Note You need to log in before you can comment on or make changes to this bug.