Bug 186871

Summary:

Add support for using localhost worker in OpenSource EWS Buildbot

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dean_johnson, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=224551

Attachments:

Description	Flags
Proposed patch	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none

Aakash Jain

Reported 2018-06-20 19:22:28 PDT

Add support for using localhost worker in OpenSource EWS (http://ews-build.webkit-uat.org) so as to ease testing and development. This is similar to what we do in other similar Buildbot related code.

Attachments
Proposed patch (2.68 KB, patch) 2018-06-20 19:31 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.26 MB, application/zip) 2018-06-20 21:19 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-06-20 19:31:00 PDT

Created attachment 343200 [details] Proposed patch

EWS Watchlist

Comment 2 2018-06-20 21:19:19 PDT Comment hidden (obsolete)

Comment on attachment 343200 [details] Proposed patch Attachment 343200 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8272582 New failing tests: imported/w3c/web-platform-tests/workers/semantics/structured-clone/dedicated.html

EWS Watchlist

Comment 3 2018-06-20 21:19:20 PDT Comment hidden (obsolete)

Created attachment 343211 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4

Lucas Forschler

Comment 4 2018-06-21 11:12:01 PDT

Comment on attachment 343200 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=343200&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:4 > Can you put this in sorted order?

Aakash Jain

Comment 5 2018-06-21 11:26:32 PDT

> Can you put this in sorted order? This was not sorted intentionally, in order to separate standard library import from and importing our files. Similar to what we do in other places, e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py#L31 https://www.python.org/dev/peps/pep-0008/#imports PEP8: Imports should be grouped in the following order: Standard library imports. Related third party imports. Local application/library specific imports.

Aakash Jain

Comment 6 2018-06-21 11:53:52 PDT

Committed r233047: <https://trac.webkit.org/changeset/233047>

Radar WebKit Bug Importer

Comment 7 2018-06-21 11:54:20 PDT

<rdar://problem/41337971>

Note You need to log in before you can comment on or make changes to this bug.