| Summary: | [Fullscreen] Use secondary glyph style for fullscreen controls | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, ews-watchlist, jeremyj-wk, jonlee, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jer Noble
2018-06-20 14:52:14 PDT
Created attachment 343183 [details]
Patch
Created attachment 343189 [details]
Patch
Comment on attachment 343189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343189&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:51 > + CGRect frame = CGRectMake(0, 0, 100, 100); Where does this 100 come from? > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:59 > + _backgroundView = [allocAVBackgroundViewInstance() initWithFrame:frame]; Why does this not sit in a RetainPtr? > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:71 > +- (void)addArrangedSubview:(UIView *)subview applyingMaterialStyle:(AVBackgroundViewMaterialStyle)materialStyle tintEffectStyle:(AVBackgroundViewTintEffectStyle)tintEffectStyle Probably you want a leading underscore here? Or is this an override of a real thing? Seems not to be. Comment on attachment 343189 [details] Patch Attachment 343189 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8277244 New failing tests: http/tests/preload/onload_event.html Created attachment 343239 [details]
Archive of layout-test-results from ews205 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 343252 [details]
Patch for landing
Comment on attachment 343252 [details] Patch for landing Clearing flags on attachment: 343252 Committed r233052: <https://trac.webkit.org/changeset/233052> All reviewed patches have been landed. Closing bug. |