Bug 186862

Summary: [Fullscreen] Use secondary glyph style for fullscreen controls
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, ews-watchlist, jeremyj-wk, jonlee, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews205 for win-future
none
Patch for landing none

Jer Noble
Reported 2018-06-20 14:52:14 PDT
[Fullscreen] Use secondary glyph style for fullscreen controls
Attachments
Patch (18.07 KB, patch)
2018-06-20 14:56 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (18.37 KB, patch)
2018-06-20 16:33 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.80 MB, application/zip)
2018-06-21 08:47 PDT, EWS Watchlist 		no flags
Details
Patch for landing (18.33 KB, patch)
2018-06-21 11:20 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-06-20 14:52:56 PDT
<rdar://problem/41212210>
Jer Noble
Comment 2 2018-06-20 14:56:11 PDT
Created attachment 343183 [details] Patch
Jer Noble
Comment 3 2018-06-20 16:33:53 PDT
Created attachment 343189 [details] Patch
Tim Horton
Comment 4 2018-06-20 23:59:29 PDT
Comment on attachment 343189 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343189&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:51 > + CGRect frame = CGRectMake(0, 0, 100, 100); Where does this 100 come from? > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:59 > + _backgroundView = [allocAVBackgroundViewInstance() initWithFrame:frame]; Why does this not sit in a RetainPtr? > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:71 > +- (void)addArrangedSubview:(UIView *)subview applyingMaterialStyle:(AVBackgroundViewMaterialStyle)materialStyle tintEffectStyle:(AVBackgroundViewTintEffectStyle)tintEffectStyle Probably you want a leading underscore here? Or is this an override of a real thing? Seems not to be.
EWS Watchlist
Comment 5 2018-06-21 08:46:53 PDT
Comment on attachment 343189 [details] Patch Attachment 343189 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8277244 New failing tests: http/tests/preload/onload_event.html
EWS Watchlist
Comment 6 2018-06-21 08:47:04 PDT
Created attachment 343239 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Jer Noble
Comment 7 2018-06-21 11:20:35 PDT
Created attachment 343252 [details] Patch for landing
WebKit Commit Bot
Comment 8 2018-06-21 11:59:18 PDT
Comment on attachment 343252 [details] Patch for landing Clearing flags on attachment: 343252 Committed r233052: <https://trac.webkit.org/changeset/233052>
WebKit Commit Bot
Comment 9 2018-06-21 11:59:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.