Bug 18686

Summary: SQUIRRELFISH: implement LabelNode
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 18624    
Attachments:
Description Flags
Proposed patch
none
Revised proposed patch
oliver: review+
Revised proposed patch oliver: review+

Description Cameron Zwarich (cpst) 2008-04-22 15:16:58 PDT 
LabelNode currently emits code for the enclosing statement but nothing else. This causes a number of JavaScriptCore tests to fail.
Comment 1 Cameron Zwarich (cpst) 2008-04-22 15:18:29 PDT 
Created attachment 20758 [details]
Proposed patch

This patch fixes 5 JavaScriptCore tests.
Comment 2 Oliver Hunt 2008-04-22 15:39:04 PDT 
Comment on attachment 20758 [details]
Proposed patch

removed review flag as we discussed this allows some incorrect behaviour :(
Comment 3 Cameron Zwarich (cpst) 2008-04-22 16:17:48 PDT 
Created attachment 20759 [details]
Revised proposed patch

This patch addresses the issues that Oliver and I discussed on IRC.
Comment 4 Oliver Hunt 2008-04-22 16:50:21 PDT 
Comment on attachment 20759 [details]
Revised proposed patch

r=me with a better name than "possibleEmptyBreakTarget"
Comment 5 Cameron Zwarich (cpst) 2008-04-22 16:55:42 PDT 
Created attachment 20760 [details]
Revised proposed patch

Here it is, with a better name.