Bug 18686

Summary:

SQUIRRELFISH: implement LabelNode

Product:

WebKit

Reporter:

Cameron Zwarich (cpst) <zwarich>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

Attachments:

Cameron Zwarich (cpst)

Reported 2008-04-22 15:16:58 PDT

LabelNode currently emits code for the enclosing statement but nothing else. This causes a number of JavaScriptCore tests to fail.

Attachments
Proposed patch (1.47 KB, patch) 2008-04-22 15:18 PDT, Cameron Zwarich (cpst)	no flags	Details Formatted Diff Diff
Revised proposed patch (8.38 KB, patch) 2008-04-22 16:17 PDT, Cameron Zwarich (cpst)	oliver: review+	Details Formatted Diff Diff
Revised proposed patch (8.63 KB, patch) 2008-04-22 16:55 PDT, Cameron Zwarich (cpst)	oliver: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Cameron Zwarich (cpst)

Comment 1 2008-04-22 15:18:29 PDT

Created attachment 20758 [details] Proposed patch This patch fixes 5 JavaScriptCore tests.

Oliver Hunt

Comment 2 2008-04-22 15:39:04 PDT

Comment on attachment 20758 [details] Proposed patch removed review flag as we discussed this allows some incorrect behaviour :(

Cameron Zwarich (cpst)

Comment 3 2008-04-22 16:17:48 PDT

Created attachment 20759 [details] Revised proposed patch This patch addresses the issues that Oliver and I discussed on IRC.

Oliver Hunt

Comment 4 2008-04-22 16:50:21 PDT

Comment on attachment 20759 [details] Revised proposed patch r=me with a better name than "possibleEmptyBreakTarget"

Cameron Zwarich (cpst)

Comment 5 2008-04-22 16:55:42 PDT

Created attachment 20760 [details] Revised proposed patch Here it is, with a better name.

Note You need to log in before you can comment on or make changes to this bug.